New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to grype 0.16.0 and add tests #102 #112
Conversation
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! Just a few questions for you
- uses: actions/checkout@v2 | ||
- run: echo $(uname -a) | ||
- name: Check for npm (so make test works) | ||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth trying to have all of these steps be available as make tasks? (For local use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are not required for local use, running make test
will cause this workflow to be executed and that's why it's needed because act
is giving a container without node for some unexplained reason. but ALSO it's just easier to install node
& docker
& add the registry container and then run jest
directly because you can easily debug the code and such.
.PHONY: test | ||
test: run-docker-registry bootstrap | ||
npm run build | ||
./act -v -P ubuntu-latest=ghcr.io/catthehacker/ubuntu:js-latest -j test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have missed it — are we explicitly installing act
somewhere in this setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, in bootstrap
. the python functional tests are running act
locally AND when run on github. this is not ideal, but i didn't change this behavior. the new jest tests are being run directly from npm on the github runner
@kzantow Also, are we at a point now where it's worth adding additional status checks as required for this repo? (Currently the only required check is DCO.) |
I think so, this would mean at least that tests don't go stale! :) |
Okay awesome. Should I just make ALL of the checks showing up on this PR required? |
This fixes: #102